aboutsummaryrefslogtreecommitdiff
path: root/module/vcomponent
diff options
context:
space:
mode:
authorHugo Hörnquist <hugo@lysator.liu.se>2020-06-12 23:11:39 +0200
committerHugo Hörnquist <hugo@lysator.liu.se>2020-06-12 23:16:51 +0200
commit787972d91b0eb51f5851ecbc4d7028d8e09ec327 (patch)
tree079f3d0149197fcadd4c3961597e329e2284fa77 /module/vcomponent
parentAdd benchmarking script. (diff)
downloadcalp-787972d91b0eb51f5851ecbc4d7028d8e09ec327.tar.gz
calp-787972d91b0eb51f5851ecbc4d7028d8e09ec327.tar.xz
Resolve some TODO's.
Diffstat (limited to 'module/vcomponent')
-rw-r--r--module/vcomponent/parse.scm2
-rw-r--r--module/vcomponent/recurrence/generate.scm1
-rw-r--r--module/vcomponent/recurrence/parse.scm3
3 files changed, 2 insertions, 4 deletions
diff --git a/module/vcomponent/parse.scm b/module/vcomponent/parse.scm
index 55cf706f..960fb6eb 100644
--- a/module/vcomponent/parse.scm
+++ b/module/vcomponent/parse.scm
@@ -59,8 +59,6 @@
;; NOTE These events also share UID, but are diferentiated
;; by RECURRENCE-ID. As far as I can tell this goes against
;; the standard. Section 3.8.4.4.
- ;; TODO Also make this grouping when reading in a whole
- ;; icalendar-file (one with multiple events)
(case (length events)
[(0) (warning "No events in component~%~a"
(attr item 'X-HNH-FILENAME))]
diff --git a/module/vcomponent/recurrence/generate.scm b/module/vcomponent/recurrence/generate.scm
index 91cd5ee2..acc45b33 100644
--- a/module/vcomponent/recurrence/generate.scm
+++ b/module/vcomponent/recurrence/generate.scm
@@ -287,7 +287,6 @@
[(BYMONTH) (memv (month d) values)]
[(BYMONTHDAY) (memv (day d) (map (month-mod d) values))]
[(BYYEARDAY) (memv (year-day d) values)]
- ;; TODO special cases?
[(BYDAY) (memv (week-day d) (map cdr values))]
[(BYHOUR) (memv (hour t) values)]
[(BYMINUTE) (memv (minute t) values)]
diff --git a/module/vcomponent/recurrence/parse.scm b/module/vcomponent/recurrence/parse.scm
index 1c611890..3df5cc25 100644
--- a/module/vcomponent/recurrence/parse.scm
+++ b/module/vcomponent/recurrence/parse.scm
@@ -85,7 +85,8 @@
(num (string->number val))
(nums (map string->number (string-split val #\,))))
- ;; TODO I think it's an error to give BYHOUR and under for dates which aren't datetimes
+ ;; It's an error to give BYHOUR and smaller for pure dates.
+ ;; 3.3.10. p 41
(quick-case (string->symbol key)
(UNTIL (set (until o) date))