aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHugo Hörnquist <hugo@lysator.liu.se>2023-10-02 19:28:31 +0200
committerHugo Hörnquist <hugo@lysator.liu.se>2023-10-02 19:28:44 +0200
commit212f953dc78c666cdf5d96b9cc8fb95bc56b405e (patch)
tree392129a76d448a78a2c341d9c08986448e2ff053
parentDocumentation work. (diff)
downloadcalp-212f953dc78c666cdf5d96b9cc8fb95bc56b405e.tar.gz
calp-212f953dc78c666cdf5d96b9cc8fb95bc56b405e.tar.xz
Add TODO comments.
-rw-r--r--module/hnh/util.scm1
-rw-r--r--module/hnh/util/object.scm2
-rw-r--r--module/scripts/module-imports.scm3
-rw-r--r--module/vcomponent/formats/common/types.scm1
-rw-r--r--module/xdg/basedir.scm3
5 files changed, 9 insertions, 1 deletions
diff --git a/module/hnh/util.scm b/module/hnh/util.scm
index 9f71c1ec..d888bea6 100644
--- a/module/hnh/util.scm
+++ b/module/hnh/util.scm
@@ -489,6 +489,7 @@
;; Non-destructive set, syntax extension from set-fields from (srfi
;; srfi-9 gnu).
+;;; TODO remove this, it's replaced by the true lens version
(define-syntax set
(syntax-rules (=)
[(set (acc obj) value)
diff --git a/module/hnh/util/object.scm b/module/hnh/util/object.scm
index 4477b462..fe5d9873 100644
--- a/module/hnh/util/object.scm
+++ b/module/hnh/util/object.scm
@@ -130,9 +130,11 @@
;; only dependant on the source from which they orginate, which leads to
;; multiple instances of <type> being equal for similar types...
;; See the manual 6.10.10 Hygiene and the Top-Level
+ ;; They technically shouldn't be exposed, but are as a side effect.
(with-syntax ((<type> (construct-syntax stx #'name "<~a>"))
(make-<type> (construct-syntax stx #'name "make-~a%")))
#`(begin
+ ;; Define actual type
(define-immutable-record-type <type>
(make-<type> #,@(map syntax-first #'(field ...)))
<type>?
diff --git a/module/scripts/module-imports.scm b/module/scripts/module-imports.scm
index 8f9ab1b8..7758c53a 100644
--- a/module/scripts/module-imports.scm
+++ b/module/scripts/module-imports.scm
@@ -5,6 +5,9 @@
;;; but simple looks at all unique symbols in the source file for what
;;; is used, which might lead to some discrepancies.
;;;
+;;; TODO An explicit #:select list in an import leads this module
+;;; to assume that all those symbols are in use
+;;;
;;; Code:
(define-module (scripts module-imports)
diff --git a/module/vcomponent/formats/common/types.scm b/module/vcomponent/formats/common/types.scm
index fcb2b7b6..68679fbc 100644
--- a/module/vcomponent/formats/common/types.scm
+++ b/module/vcomponent/formats/common/types.scm
@@ -37,6 +37,7 @@
(define (parse-datetime props value)
(define parsed
(parse-ics-datetime
+ ;; TODO props is no longer a (built-in) hash table
value (hashq-ref props 'TZID #f)))
(hashq-set! props '-X-HNH-ORIGINAL parsed)
(get-datetime parsed))
diff --git a/module/xdg/basedir.scm b/module/xdg/basedir.scm
index f4e7b89b..4f9b8e3b 100644
--- a/module/xdg/basedir.scm
+++ b/module/xdg/basedir.scm
@@ -12,7 +12,8 @@
(cond ((getenv var)
=> (lambda (s)
(if (string-null? s)
- #f s)))
+ #f
+ s)))
(else #f)))
;;; XDG_DATA_HOME