From 212f953dc78c666cdf5d96b9cc8fb95bc56b405e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hugo=20H=C3=B6rnquist?= <hugo@lysator.liu.se>
Date: Mon, 2 Oct 2023 19:28:31 +0200
Subject: Add TODO comments.

---
 module/hnh/util.scm                        | 1 +
 module/hnh/util/object.scm                 | 2 ++
 module/scripts/module-imports.scm          | 3 +++
 module/vcomponent/formats/common/types.scm | 1 +
 module/xdg/basedir.scm                     | 3 ++-
 5 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/module/hnh/util.scm b/module/hnh/util.scm
index 9f71c1ec..d888bea6 100644
--- a/module/hnh/util.scm
+++ b/module/hnh/util.scm
@@ -489,6 +489,7 @@
 
 ;; Non-destructive set, syntax extension from set-fields from (srfi
 ;; srfi-9 gnu).
+;;; TODO remove this, it's replaced by the true lens version
 (define-syntax set
   (syntax-rules (=)
     [(set (acc obj) value)
diff --git a/module/hnh/util/object.scm b/module/hnh/util/object.scm
index 4477b462..fe5d9873 100644
--- a/module/hnh/util/object.scm
+++ b/module/hnh/util/object.scm
@@ -130,9 +130,11 @@
        ;; only dependant on the source from which they orginate, which leads to
        ;; multiple instances of <type> being equal for similar types...
        ;; See the manual 6.10.10 Hygiene and the Top-Level
+       ;; They technically shouldn't be exposed, but are as a side effect.
        (with-syntax ((<type>      (construct-syntax stx #'name "<~a>"))
                      (make-<type> (construct-syntax stx #'name "make-~a%")))
          #`(begin
+             ;; Define actual type
              (define-immutable-record-type <type>
                (make-<type> #,@(map syntax-first #'(field ...)))
                <type>?
diff --git a/module/scripts/module-imports.scm b/module/scripts/module-imports.scm
index 8f9ab1b8..7758c53a 100644
--- a/module/scripts/module-imports.scm
+++ b/module/scripts/module-imports.scm
@@ -5,6 +5,9 @@
 ;;; but simple looks at all unique symbols in the source file for what
 ;;; is used, which might lead to some discrepancies.
 ;;;
+;;; TODO An explicit #:select list in an import leads this module
+;;;   to assume that all those symbols are in use
+;;;
 ;;; Code:
 
 (define-module (scripts module-imports)
diff --git a/module/vcomponent/formats/common/types.scm b/module/vcomponent/formats/common/types.scm
index fcb2b7b6..68679fbc 100644
--- a/module/vcomponent/formats/common/types.scm
+++ b/module/vcomponent/formats/common/types.scm
@@ -37,6 +37,7 @@
 (define (parse-datetime props value)
   (define parsed
     (parse-ics-datetime
+     ;; TODO props is no longer a (built-in) hash table
      value (hashq-ref props 'TZID #f)))
   (hashq-set! props '-X-HNH-ORIGINAL parsed)
   (get-datetime parsed))
diff --git a/module/xdg/basedir.scm b/module/xdg/basedir.scm
index f4e7b89b..4f9b8e3b 100644
--- a/module/xdg/basedir.scm
+++ b/module/xdg/basedir.scm
@@ -12,7 +12,8 @@
   (cond ((getenv var)
          => (lambda (s)
               (if (string-null? s)
-                  #f s)))
+                  #f
+                  s)))
         (else #f)))
 
 ;;; XDG_DATA_HOME
-- 
cgit v1.2.3