From 77da67992ef0b4cd33c21094046e2bb71a6b2f18 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hugo=20H=C3=B6rnquist?= <hugo@hornquist.se>
Date: Tue, 18 Feb 2020 01:43:18 +0100
Subject: Documentation.

---
 module/srfi/srfi-19/alt.scm | 28 +++++++++++++++++++++-------
 module/vcomponent/parse.scm | 12 +++++++-----
 2 files changed, 28 insertions(+), 12 deletions(-)

(limited to 'module')

diff --git a/module/srfi/srfi-19/alt.scm b/module/srfi/srfi-19/alt.scm
index 9f48e6ad..5feee73d 100644
--- a/module/srfi/srfi-19/alt.scm
+++ b/module/srfi/srfi-19/alt.scm
@@ -92,23 +92,30 @@
                  (or time (make-time hour minute second))
                  tz))
 
+;; datetime → datetime
+;; Takes a datetime in any timezone, and renormalize it to local time
+;; (as defined by TZ). This means that given UTC 10:00 new years day
+;; would return 11:00 new years day if ran in sweden.
 (define-public (get-datetime dt)
-
   (let ((t (get-time% dt))
         (d (get-date dt)))
+    ;; NOTE there isn't any stable way to craft the tm objects.
+    ;; I could call mktime on some date, and replace the fields
+    ;; with the set-tm:*, but that is worse that breaking the API.
     (let ((v (vector (second t)
                      (minute t)
                      (hour t)
                      (day d)
                      (1- (month d))
                      (- (year d) 1900)
-                     0
-                     0
-                     -1
-                     0 #f)))
+                     0 0                ; wday & yday (ignored)
+                     -1                 ; DST unknown
+                     0                  ; UTC offset (ignored)
+                     #f                 ; TZ name
+                     )))
       (let ((tm
-             (localtime
-              (car
+             (localtime ; localtime convertion since the returned tm object is
+              (car      ; in the parsed timezone.
                (cond [(not (tz dt)) (mktime v)]
                      [(string=? "local" (tz dt)) (mktime v)]
                      [else (mktime v (tz dt))])))))
@@ -120,6 +127,11 @@
                   second: (tm:sec  tm))))))
 
 ;; Deprecated
+;; datetime → time
+;; Returns the local time from a date. Meaning that if the given datetime has
+;; timezone info it's discarded and a local timestamp produced.
+;; It's deprecated since the local time of a datetime can be in another date
+;; than the original. which is fun...
 (define-public (get-time dt)
   (get-time% (get-datetime dt)))
 
@@ -568,6 +580,8 @@
         minute: (s->n str 2 4)
         second: (s->n str 4 6)))
 
+;;; TODO when parsing recurrence rules sometimes I think this is
+;;; sent regular dates
 (define*-public (parse-datetime str optional: tz)
   (let* (((datestr timestr) (string-split str #\T)))
     (datetime date: (parse-date datestr)
diff --git a/module/vcomponent/parse.scm b/module/vcomponent/parse.scm
index 979eea7b..4caabe0b 100644
--- a/module/vcomponent/parse.scm
+++ b/module/vcomponent/parse.scm
@@ -241,14 +241,16 @@
                   (increment-column! ctx)]))))
 
           (lambda _
-            (format (current-error-port)
-                    "== PARSE ERROR ==
+            ;; display is atomic, format isn't
+            (display
+             (format #f
+                     "== PARSE ERROR ==
 filename = ~a
 row ~a	column ~a	ctx = ~a
 ~a ; ~a = ... : ...~%~%"
-                    (get-filename ctx)
-                    (get-row ctx) (get-col ctx) (get-ctx ctx)
-                    (get-line-key ctx) (get-param-key ctx))))))))
+                     (get-filename ctx)
+                     (get-row ctx) (get-col ctx) (get-ctx ctx)
+                     (get-line-key ctx) (get-param-key ctx)))))))))
 
 
 
-- 
cgit v1.2.3