From 973708409481ea5e0d614c3ac6b6f1c96413caad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hugo=20H=C3=B6rnquist?= Date: Thu, 13 Aug 2020 10:11:14 +0200 Subject: Popups are now correcetly rooted. --- module/html/view/calendar.scm | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'module/html/view/calendar.scm') diff --git a/module/html/view/calendar.scm b/module/html/view/calendar.scm index 2371cfe0..52e42078 100644 --- a/module/html/view/calendar.scm +++ b/module/html/view/calendar.scm @@ -97,6 +97,10 @@ (define repo-url (make-parameter "https://git.hornquist.se")) + +;; TODO document what @var{render-calendar} is supposed to take and return. +;; Can at least note that @var{render-calendar} is strongly encouraged to include +;; (script "const VIEW='??';"), where ?? is replaced by the name of the view. (define*-public (html-generate key: (intervaltype 'all) ; 'week | 'month | 'all @@ -179,10 +183,11 @@ next-start: next-start prev-start: prev-start ) - - ,@(for event in (stream->list - (events-between pre-start post-end events)) - (popup event (string-append "popup" (html-id event))))) + ;; Popups used to be here, but was moved into render-calendar so each + ;; sub-view can itself decide where to put them. This is important + ;; since they need to be placed as children to the scrolling + ;; component, if one such component exists. + ) ;; Page footer (footer -- cgit v1.2.3