aboutsummaryrefslogtreecommitdiff
path: root/module/vcomponent/base.scm
diff options
context:
space:
mode:
authorHugo Hörnquist <hugo@lysator.liu.se>2023-04-10 22:49:23 +0200
committerHugo Hörnquist <hugo@lysator.liu.se>2023-04-10 23:45:29 +0200
commit9c1a4b809a8c723114a6b86262b340bf66429a10 (patch)
tree1a8c4e86b9f7de288ec6a13e30bffd00f463218a /module/vcomponent/base.scm
parentAdd (sxml namespaced). (diff)
downloadcalp-9c1a4b809a8c723114a6b86262b340bf66429a10.tar.gz
calp-9c1a4b809a8c723114a6b86262b340bf66429a10.tar.xz
Add various TODOs
Diffstat (limited to 'module/vcomponent/base.scm')
-rw-r--r--module/vcomponent/base.scm4
1 files changed, 4 insertions, 0 deletions
diff --git a/module/vcomponent/base.scm b/module/vcomponent/base.scm
index 2da939d0..e4982336 100644
--- a/module/vcomponent/base.scm
+++ b/module/vcomponent/base.scm
@@ -98,6 +98,8 @@
(define* (make-vcomponent optional: (type 'VIRTUAL))
(make-vcomponent% type '() (make-hash-table)))
+;; TODO should this be renamed to `adopt!'? Adopting a child better implies
+;; that the old parent should no longer be considered its parent.
(define (reparent! parent child)
(set-component-children! parent (cons child (children parent)))
(set! (parent% child) parent))
@@ -107,6 +109,8 @@
(when (eq? parent-component (parent% child))
(orphan! child)))
+;; TODO should this exist? It's really weird to remove our reference to our
+;; parent, without the parent removing their reference to us.
(define (orphan! child)
(set! (parent% child) #f))