aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHugo Hörnquist <hugo@lysator.liu.se>2023-04-10 22:49:23 +0200
committerHugo Hörnquist <hugo@lysator.liu.se>2023-04-10 23:45:29 +0200
commit9c1a4b809a8c723114a6b86262b340bf66429a10 (patch)
tree1a8c4e86b9f7de288ec6a13e30bffd00f463218a
parentAdd (sxml namespaced). (diff)
downloadcalp-9c1a4b809a8c723114a6b86262b340bf66429a10.tar.gz
calp-9c1a4b809a8c723114a6b86262b340bf66429a10.tar.xz
Add various TODOs
-rw-r--r--module/calp/html/view/search.scm2
-rw-r--r--module/calp/server/server.scm1
-rw-r--r--module/calp/terminal.scm4
-rw-r--r--module/vcomponent/base.scm4
-rw-r--r--module/web/http/make-routes.scm2
5 files changed, 13 insertions, 0 deletions
diff --git a/module/calp/html/view/search.scm b/module/calp/html/view/search.scm
index 7b991104..e400c1ba 100644
--- a/module/calp/html/view/search.scm
+++ b/module/calp/html/view/search.scm
@@ -31,6 +31,8 @@
(body
(a (@ (href ("/today"))) ,(G_ "Show today"))
(h2 ,(G_ "Search term"))
+ ;; TODO add blurb documenting available variables here,
+ ;; and link to full documentation page
(form
(pre (textarea (@ (name "q") (rows 5) (spellcheck false)
(style "width:100%"))
diff --git a/module/calp/server/server.scm b/module/calp/server/server.scm
index f2d58337..04d33ba5 100644
--- a/module/calp/server/server.scm
+++ b/module/calp/server/server.scm
@@ -7,6 +7,7 @@
:export (start-server))
+;;; TODO Do I really want this hardcoded here?
(define handler (make-make-routes))
;; NOTE The default make-default-socket is broken for IPv6.
diff --git a/module/calp/terminal.scm b/module/calp/terminal.scm
index 04effd68..12609e17 100644
--- a/module/calp/terminal.scm
+++ b/module/calp/terminal.scm
@@ -290,6 +290,7 @@
">")))
(newline))
+;;; TODO what is this view?
(define-method (input (this <view>) char)
(case char
((#\j #\J down) (unless (= (active-element this) (1- (page-length this)))
@@ -300,6 +301,9 @@
((#\g) (set! (active-element this) 0))
((#\G) (set! (active-element this) (1- (page-length this))))
+ ;; TODO Launch edit mode!
+ ;; TODO should edit mode be here?
+ ((#\e) 'NOOP)
((#\q) '(pop)))
diff --git a/module/vcomponent/base.scm b/module/vcomponent/base.scm
index 2da939d0..e4982336 100644
--- a/module/vcomponent/base.scm
+++ b/module/vcomponent/base.scm
@@ -98,6 +98,8 @@
(define* (make-vcomponent optional: (type 'VIRTUAL))
(make-vcomponent% type '() (make-hash-table)))
+;; TODO should this be renamed to `adopt!'? Adopting a child better implies
+;; that the old parent should no longer be considered its parent.
(define (reparent! parent child)
(set-component-children! parent (cons child (children parent)))
(set! (parent% child) parent))
@@ -107,6 +109,8 @@
(when (eq? parent-component (parent% child))
(orphan! child)))
+;; TODO should this exist? It's really weird to remove our reference to our
+;; parent, without the parent removing their reference to us.
(define (orphan! child)
(set! (parent% child) #f))
diff --git a/module/web/http/make-routes.scm b/module/web/http/make-routes.scm
index feba3f19..f83b2f34 100644
--- a/module/web/http/make-routes.scm
+++ b/module/web/http/make-routes.scm
@@ -145,6 +145,8 @@
;; TODO propper logging
(display (format #f "[~a] ~a ~a:~a~a?~a~%"
+ ;; TODO does this even work? Maybe it works due to datetime
+ ;; being included at all expansion points.
(datetime->string (current-datetime))
r:method r:host r:port r:path (or r:query ""))
(current-error-port))